Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v23.2.x] archival/test: Ensure archiver is stopped #15177

Merged

Conversation

vbotbuildovich
Copy link
Collaborator

Backport of PR #15169
Fixes: #15176,

If the test affected by this change fails, archiver is destroyed without
stopping. This also destroys the scrubber, which may have requests
active keeping its gate open.

This triggers an assertion from seastar related to gate destroyed while
requests active. Usually this is prominently visible but in this test it
results in the ctest invocation hanging in CI.

This causes the build to hang and timeout. The root cause is the
test_manifest_spillover not adding segments to the archival meta STM,
which can be investigated separately. This change should enable the test
to fail in a visible manner with logs seen in CI instead of hanging.

(cherry picked from commit ef8a420)
@vbotbuildovich vbotbuildovich added this to the v23.2.x-next milestone Nov 28, 2023
@vbotbuildovich vbotbuildovich added the kind/backport PRs targeting a stable branch label Nov 28, 2023
@abhijat abhijat marked this pull request as ready for review November 28, 2023 15:28
@abhijat abhijat merged commit 65e8630 into redpanda-data:v23.2.x Nov 29, 2023
25 checks passed
@piyushredpanda piyushredpanda modified the milestones: v23.2.x-next, v23.2.18 Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/redpanda kind/backport PRs targeting a stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants